LinkControl: Prevent horizontally long preview image from being stretched vertically #55156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +26 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1941031. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6455017955
|
|
Thanks for the review, @ntsekouras! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue where if the image ratio is long horizontally relative to the LinkControl's preview area ratio, it will be stretched vertically.
Example: https://make.wordpress.org/chat/
Why?
height:100%stretches the image to fill the container, which has a height of 140px.This is fine for regular images, but if the image is long relative to the container's aspect ratio, it will be unintentionally stretched vertically.
How?
I used object-fit:contain to fit the image within the container area while maintaining the image's aspect ratio.
Testing Instructions
https://make.wordpress.org/chat/.