Use accessorFn instead of cell to render status
#55196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Feature] Site Editor
|
Size Change: -2 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Oct 10, 2023
Thanks for the brain dump! Trying to wrap my head around this tanstack thing, so this is helpful. |
oandregal
commented
Oct 10, 2023
| cell: ( props ) => | ||
| postStatuses[ props.row.original.status ] ?? | ||
| props.row.original.status, | ||
| accessorFn: ( page ) => |
There was a problem hiding this comment.
So, apparently, when a field has an accessorFn the column is automatically made sortable, unless set otherwise. Fix at #55210
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #54966
What?
The fields (ColumnsDef in tanstack) provide two functions to render data for each cell: accessorFn and cell. We were using
cellto provide the data for thestatusbut we should useaccessorFninstead.Why?
The
accessorFnis the callback that provides the value for this cell. On the other hand,cellis for rendering the data in the UI should you want to render anything different from the value (e.g.: wrap the value into a link, add a text transformation, etc.).For example, let's say a cell wanted to access the value of
statusfor its row. This is how you do it:However, because the
statusrow does not provide anyaccessorFn,props.row.getValue( 'status' )returns undefined. This PR fixes it and makes it return the proper value.Testing Instructions
Tests that it works as before visually for users:
Make sure the value is returned for the cell: