Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox: Re-use existing Tag Processor instance. #55281

Closed
wants to merge 2 commits into from
Closed

Lightbox: Re-use existing Tag Processor instance. #55281

wants to merge 2 commits into from

Commits on Oct 16, 2023

  1. Lightbox: Re-use existing Tag Processor instance. (#55281) 

    Companion work in WordPress/wordpress-develop#5428

Resolves #55123

This patch refactors the use of the HTML API in image lightbox rendering.
It replaces creating multiple Tag Processor instances with the use of a
single instance that rewinds and jumps around to perform multiple jobs
on a single instance.

Also incorporated is a fix for bailing out when no images are in a given
image block's output HTML.
    @dmsnell
    dmsnell committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7b3ec58 View commit details
    Browse the repository at this point in the history

  2. fixup! Lightbox: Re-use existing Tag Processor instance. (#55281)

    @dmsnell
    dmsnell committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    0c0f5bc View commit details
    Browse the repository at this point in the history