DataViews: Update the view actions menu to be independent from current view APIs #55294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: +124 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d6ffd2323bb76461d2883b0c3bd1d5955e59475f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6493945706
|
|
Just did a quick test and it breaks when we reset the sorting. |
youknowriad
force-pushed
the
update/view-config-component
branch
from
d6ffd23 to
43b8b10
Compare
|
@ntsekouras Rebased and fixed the reset issue. |
ntsekouras
reviewed
Oct 12, 2023
| onSelect={ ( event ) => { | ||
| event.preventDefault(); | ||
| if ( sortedDirection === direction ) { | ||
| dataView.resetSorting(); |
There was a problem hiding this comment.
I see you separated the code again here. That's fine, but the plan is to update the code here to update the view, right?
There was a problem hiding this comment.
I don't really know whether we should merge the two, especially since list view heavily depends on tanstack. We'll see how that menu grows.
There was a problem hiding this comment.
Yeah, we'll see, but I think we can use tanstack for the other views too(at least the simpler ones like grid, etc..).
justintadlock
added
the
[Feature] DataViews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
This is PR is a prerequisite to implement alternative views (grid) for the DataViews component. The "DataViews" menu is common to all view types, so it shouldn't be using internal APIs that are specific to one given view type (tan stack APIs). So this PR refactors that component to rely on the
viewandfieldsobject instead ofdataViewobject that we receive from tanstack.Testing Instructions
1- Open the browse all pages in the site editor
2- Use the view actions menu (top right) to tweak the sort, the visibility of fields...