Migrate 'Post Title block' e2e tests to Playwright #55297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Justin Ahinon <justiny.ahinon@gmail.com> Co-authored-by: Alvi Tazwar <55917380+alvitazwar@users.noreply.github.com>
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
commented
Oct 12, 2023
Comment on lines
21
to
27
| // Save the post draft and reload. | ||
| await page.getByRole( 'button', { name: 'Save draft' } ).click(); | ||
| await expect( | ||
| page | ||
| .getByRole( 'button', { name: 'Dismiss this notice' } ) | ||
| .filter( { hasText: 'Draft saved' } ) | ||
| ).toBeVisible(); |
There was a problem hiding this comment.
Maybe it's time to add the editor.saveDraft() helper. There are at least 20 occurrences of similar logic in the tests.
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Supersedes and closes #41107.
Supersedes and closes #43989.
PR migrated
post-title.test.jse2e tests to Playwright.Why?
See #38851.
How?
Using best practices and migration guide.
Testing Instructions