Text Block: When splitting a text block, avoid empty paragraphs at the begining of the created block #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Blocks
mtias
reviewed
Apr 28, 2017
blocks/components/editable/index.js
Outdated
| @@ -170,13 +170,17 @@ export default class Editable extends wp.element.Component { | |||
| return; | |||
| } | |||
| const before = getHtml( beforeNodes.slice( 0, beforeNodes.length - 1 ) ); | |||
| const after = getHtml( childNodes.slice( splitIndex ).reduce( ( memo, node ) => { | |||
There was a problem hiding this comment.
A comment explaining the why could be useful for the future.
…e begining of the created block
youknowriad
force-pushed
the
fix/empty-paragraph-when-splitting
branch
from
0ffc5d7
to
4d64739
Compare
|
Mmm, this is now creating two empty paragraphs on second enter and not splitting :) |
|
Nice, looks good to me. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #543
Testing instructions
When putting the cursor in an empty line of a text block and splitting this text block, the empty line should be dropped from the created block.