Rich Text: Replace named character entities. #55364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -63 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 793fda0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9770767970
|
Allows entering named character references by their name for convenient entry. For example, typing `¬in` will be replaced with `∉` when completing the sequence with `;`.
dmsnell
force-pushed
the
rich-text/replace-named-character-references
branch
from
e10c418 to
793fda0
Compare
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@ellatrix do you have thoughts on this? it would be a nice addition IMO, but I'm sure the code as written should be adjusted to match styles and conventions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows entering named character references by their name for convenient entry. For example, typing
¬inwill be replaced with∉when completing the sequence with;.WordPress itself corrupts named character references not in its list of HTML4 names plus a few extra, meaning that it's not possible to use these for entry. In this patch these are replaced while editing so that they are stored as the actual code points and not as the references, thus passing through Core safely.
Screen.Recording.2023-10-13.at.3.43.09.PM.mov