Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query block: remove unnecessary class #55438

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

luisherranz
Copy link
Member

What?

Remove an unnecessary class on the Query block.

Mentioned in #55309 (comment).

Why?

Because nobody has a real need for that class yet and we are not using it. By exposing it, we will introduce a breaking change if we want to change it later.

How?

Just remove it.

Testing Instructions

Check that the screen reader keeps working fine when the enhanced pagination is enabled.

@luisherranz luisherranz added [Type] Code Quality Issues or PRs that relate to code quality [Block] Query Loop Affects the Query Loop Block labels Oct 18, 2023
@luisherranz luisherranz self-assigned this Oct 18, 2023
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal merged commit a8f3aca into trunk Oct 18, 2023
57 checks passed
@cbravobernal cbravobernal deleted the remove-unnecessary-class-on-the-query-block branch October 18, 2023 11:10
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 18, 2023
@luisherranz luisherranz added [Type] Regression Related to a regression in the latest release and removed [Type] Code Quality Issues or PRs that relate to code quality labels Nov 2, 2023
@luisherranz
Copy link
Member Author

I'm flagging this for 6.4.1 as this removes an unnecessary class that was introduced in 6.4, and it's very unlikely that somebody is referencing it in such a short time. However, if it's already too late to remove it, please let me know so I can revert this change in Gutenberg as well. Thanks.

@luisherranz luisherranz added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 2, 2023
@mikachan
Copy link
Member

mikachan commented Nov 9, 2023

I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: 4d1bfd2

mikachan pushed a commit that referenced this pull request Nov 9, 2023
@mikachan mikachan removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 9, 2023
mikachan pushed a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants