Performance tests: Fix canvas locator timeout #55441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
WunderBart
force-pushed
the
fix/perf-tests-canvas-promise
branch
from
d1533fc
to
2d265b1
Compare
WunderBart
changed the title
WunderBart
added
the
[Type] Automated Testing
WunderBart
changed the title
This was referenced Oct 18, 2023
WunderBart
requested review from
Mamaduka,
youknowriad,
kevin940726 and
stokesman
kevin940726
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The current
getCanvas()implementation leaves a locator timeout error in the trace zip, which can be confusing when debugging failures. It happens because we're usingPromise.any()to detect which canvas selector – legacy or iframed – is found first. While the ignored promise doesn't fail a test, it will asynchronously throw a timeout error in the trace file, which can be misleading when inspecting that trace.Additionally, replace the per case increased timeouts with a globally increased
actionTimeoutfor the performance tests. Giving all the actions more time makes more sense since we're often testing against large content in both post and site editors.Testing Instructions
All tests should pass.