Author, Author Bio, Author Name: Add a fallback for Author Archive Template

[t-hamano]

Fixes #55410
Similar to #40648

Props to @them-es for reporting the issue with this comment.

What?

This PR fixes an issue where the block is not displayed in the Author Archive template or a warning error occurs when the author has no posts in the following three blocks.

• Avatar
• Author Name
• Author Biography

Why?

These three blocks assume that a post ID context ($block->context['postId']) exists. But my understanding is that if that author hasn't posted any articles yet, the post ID context doesn't exist, so the block won't show up or you'll get an error.

Since the Author Archive page is accessible, I think they should be rendered correctly even in cases where they don't have any posts.

How?

Use author query parameter as ID when no post context exists.

Testing Instructions

• First, create a user with an avatar. For example, if you register as a user using the email address below, the avatar will be displayed.
  • test1@example.com
  • test2@example.com
  • test3@example.com
• Enter the user's biography (Also, please note the author ID).
• Create the Author Archive template in the Site Editor.
• Enter the following code in the code editor and save it.

  <!-- wp:post-author-name /-->
  <!-- wp:post-author-biography /-->
  <!-- wp:avatar /-->
  

• Access http://localhost:8888/?author={user_id}.
• Although this author does not have any posts, their avatar, name, and biography should all be displayed correctly.

[github-actions]

Flaky tests detected in 8151386.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7953908460
📝 Reported issues:

• [Flaky Test] can add submenus #50976 in /test/e2e/specs/editor/blocks/navigation-list-view.spec.js

[aaronrobertshaw]

This tests as advertised for me. Nice work @t-hamano 👍

✅ Could replicate issue on trunk
✅ Avatar, Post Author Biography, and Post Author Name blocks render correctly in author archive
✅ Updated blocks continue to work as intended in other contexts where query string arg isn't provided
✅ Couldn't spot any other blocks or locations needing the same tweak

I left one tiny nit/suggestion. Whether you adopt it or not, I'll leave up to you.

[aaronrobertshaw]

Nit: Now this conditional is more than a simple guard clause, perhaps it should test for the positive scenario? Sort of like the code style guidelines recommend for ternary operators.

I don't feel strongly about this but it might be good to have all three locations logic match at least 🤷

[t-hamano]

Thanks for the review!

I rewrote the two places by 8151386. If I rewrite this part using the ternary operator, nested conditional statements will occur, so I think it's fine as is, but what do you think?

[aaronrobertshaw]

Apologies if I wasn't clear with my suggestion. I didn't mean that you needed to change these if/else statements to ternaries, just that we should check the positive case first. Like what is suggested for when you do use ternary operators.

This is such a minor detail, don't feel you need to keep changing the code over it.

Below is a quick diff to illustrate what I was originally suggesting:

Example diff

diff --git a/packages/block-library/src/post-author-biography/index.php b/packages/block-library/src/post-author-biography/index.php
index 6c4cdc301e..23f5f16cbc 100644
--- a/packages/block-library/src/post-author-biography/index.php
+++ b/packages/block-library/src/post-author-biography/index.php
@@ -14,7 +14,11 @@
  * @return string Returns the rendered post author biography block.
  */
 function render_block_core_post_author_biography( $attributes, $content, $block ) {
-	$author_id = isset( $block->context['postId'] ) ? get_post_field( 'post_author', $block->context['postId'] ) : get_query_var( 'author' );
+	if ( isset( $block->context['postId'] ) ) {
+		$author_id = get_post_field( 'post_author', $block->context['postId'] );
+	} else {
+		$author_id = get_query_var( 'author' );
+	}
 
 	if ( empty( $author_id ) ) {
 		return '';
diff --git a/packages/block-library/src/post-author-name/index.php b/packages/block-library/src/post-author-name/index.php
index 92d37f70f9..a5fadfcbf3 100644
--- a/packages/block-library/src/post-author-name/index.php
+++ b/packages/block-library/src/post-author-name/index.php
@@ -14,7 +14,11 @@
  * @return string Returns the rendered post author name block.
  */
 function render_block_core_post_author_name( $attributes, $content, $block ) {
-	$author_id = isset( $block->context['postId'] ) ? get_post_field( 'post_author', $block->context['postId'] ) : get_query_var( 'author' );
+	if ( isset( $block->context['postId'] ) ) {
+		$author_id = get_post_field( 'post_author', $block->context['postId'] );
+	} else {
+		$author_id = get_query_var( 'author' );
+	}
 
 	if ( empty( $author_id ) ) {
 		return '';

[t-hamano]

Ah, I mistakenly thought that I should use ternary operators itself. I understand what you mean 😅

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[aaronrobertshaw]

Thanks for your patience here @t-hamano 👍

I've given this another quick smoke test and it LGTM!

🚢