-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Classic block: Add option to convert to blocks #55461
Merged
fluiddot
merged 4 commits into
trunk
from
rnmobile/update/classic-block-convert-to-blocks
Oct 20, 2023
Merged
[RNMobile] Classic block: Add option to convert to blocks #55461
fluiddot
merged 4 commits into
trunk
from
rnmobile/update/classic-block-convert-to-blocks
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
A suggestion for improvement.
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Block] Classic
Affects the Classic Editor Block
labels
Oct 18, 2023
Size Change: 0 B Total Size: 1.66 MB ℹ️ View Unchanged
|
derekblank
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was able to follow the testing steps successfully. 🚀
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Classic
Affects the Classic Editor Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add the option to convert the Classic block's content to blocks. This functionality matches the behavior we provide in the web version of the Classic block.
Why?
The Classic block is currently unsupported in the mobile native version, hence this will provide an alternative for users to edit the content.
How?
The Missing block (i.e. the block used for unsupported blocks) now checks if the original block is the Classic block. If so, it expands the description provided in the unsupported block details bottom sheet, as well as adding an action button to convert the content into blocks.
Testing Instructions
WPCOM site
Self-hosted site
Testing Instructions for Keyboard
N/A
Screenshots or screencast
ios-wpcom-classic-to-blocks.mp4
ios-self-hosted-classic-to-blocks.mp4