-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] E2E Tests - Utils - Update typeString
#55588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value before typing. This is to prevent characters being skipped when typing again.
geriux
added
[Status] In Progress
Tracking issues with work in progress
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Mobile App - Automation
Label used to initiate Mobile App PR Automation
labels
Oct 25, 2023
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
dcalhoun
approved these changes
Oct 25, 2023
geriux
removed
the
Mobile App - Automation
Label used to initiate Mobile App PR Automation
label
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
typeString
wordpress-mobile/gutenberg-mobile#6321What?
This PR adds a
pause
after clearing the initial value in thetypeString
util.Why?
There's a flaky test on iOS where it would skip typing some characters after clearing the initial value. This might be related to the performance of the editor when typing/deleting text too fast.
How?
By adding a
pause
timer after clearing the initial value.Testing Instructions
CI checks should pass in both PRs.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A