-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme JSON schema: add heading/button key to color definition #55674
Conversation
schemas/json/theme.json
Outdated
@@ -231,6 +231,16 @@ | |||
"description": "Allow users to set text colors.", | |||
"type": "boolean", | |||
"default": true | |||
}, | |||
"heading": { | |||
"description": "Allow users to set heading colors.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this confusing because it can easily be mixed up with styles > elements > headings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. What about "Allow users to set heading colors in a block."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either phrasing for the description. If we do add "in a block" to the heading
description, we should also update the description for button
, link
, and text
too.
Makes sense. The theme.json schema's |
Follow-up on #49131
Similar to #55675
What?
This PR adds heading/button key to color definition in theme.json schema.
Why?
To allow developers to design theme.json with reference to the correct schema.
Testing Instructions
Create the following JSON file locally, specifying the JSON schema changed by this PR.
button
andheading
keys listed in thesettings.color
property.button
andheading
keys listed in thesettings.block.{blockName}.color
property.true
should be set when thebutton
orheading
key is selected.