Give nice unique names to block controls HOCs #55795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
jsnajdr
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +39 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Nov 2, 2023
|
Just a heads up that this will probably conflict with #55762. Both PR modify the file with the |
|
Thanks for the heads up. It should be an easy merge conflict to resolve. |
jsnajdr
force-pushed
the
update/nice-names-for-block-controls
branch
from
6706503 to
7474029
Compare
|
But e2e tests are permanently failing. Maybe I really broke something. |
|
It's only Puppeteer e2e test and they seem to fail on trunk as well. |
|
Yep, after rebase the e2e's succeeded and the PR was auto-merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an aesthetic/devex issue where the HOCs that add block controls have undifferentiated names like
withToolbarControlsorwithInspectorControls:This PR modifies the HOC names to be specific, like
withPositionControlsorwithAlignmentControls. The HOCs that add styles and attributes (likewithPositionStyles) already use a similar convention.I'm also unifying the names to consistently use plural (controls, not control) and unifying the convention for hook names (the
core/editor/...prefix).The result looks like this in the React devtools:
How to test:
There should be no behavior change at all, we're just renaming variables, basically.