Make wp-env compatible with WordPress versions older than 5.4 by fixing wp-config anchors #55864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng wp-config anchors.
felixarntz
added
[Type] Bug
felixarntz
requested review from
noahtallen,
ObliviousHarmony and
t-hamano
as code owners
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
swissspidy
reviewed
Nov 6, 2023
swissspidy
reviewed
Nov 6, 2023
|
@ObliviousHarmony Based on the reason why the |
The anchor defaults to
|
|
@swissspidy I thought you said in #55864 (comment) that these were no longer being translated. Or was that just very recent? Maybe I misunderstood that comment. |
Just very recent. But WP 5.1 and WP 5.4 still had translated config files in many locales. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@swissspidy @ObliviousHarmony It's been a while, but I just updated this PR based on previous feedback and left another reply to the other concern. I still think this would be valuable to land as the underlying problem still persists. Would be great to get another review! |
swissspidy
reviewed
Aug 14, 2024
swissspidy
reviewed
Aug 14, 2024
swissspidy
reviewed
Aug 14, 2024
|
I confirmed that this PR works on a Windows host OS.
I too am a bit skeptical about the need to support such old WordPress versions. I'd be interested to hear other people's opinions on this too. |
|
@swissspidy @t-hamano Thanks for the review and testing! I get the general concern about supporting old WordPress versions, but I find it a bit of a moot point, for a few reasons:
I think the cost of supporting old versions is minimal (basically this PR), and with the foundation that (FWIW I personally have one of those simple plugins where I still support back to 5.0 because there's no need to require anything higher. That's how I ran into this bug.) |
|
Flaky tests detected in 1be7b01. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10394400926
|
swissspidy
approved these changes
Aug 14, 2024
felixarntz
commented
Aug 14, 2024
fabiankaegy
added
has dev note
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@wordpress/envcurrently does not support WordPress versions older than 5.4.Why?
@wordpress/envcurrently assumes certain conventions inwp-config.phpthat were not the case prior to WordPress 5.4.@wordpress/envdoes:wp-config.phpwas not using spacing correctly: Compare the 5.1 code with the 5.0 code for reference.wp-config.phpwas using the olderdirname( __FILE__ )instead of__DIR__: Compare the 5.4 code with the 5.3 code for reference.How?
wp-config.phpanchor references depending on which WordPress version is used.Testing Instructions
@wordpress/envwith different WordPress ZIP files in the.wp-env.jsonfile under"core":Error: Could not process the 'wp-config.php' transformation.ABSPATHwon't have been made. This will for instance prevent PHPUnit tests from working correctly.