Add menubar role to header when using top toolbar #55910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move isCollapsed state from the block-contextual-toolbar into the site editor header, as it is only needed and related to the site editor header. This is not a state the block toolbar needs to know about. Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
Allows block tools in dom header to overflow scroll using flex-shrink. Every element parent of the scrolling toolbar needs an overflow-x: hidden and flex-shrink: 2 (or higher) value. Also sets the small screen size to have the fixed toolbar underneath the header bar.
There were two forms of the small screen top toolbar -- one when the top toolbar option was on, and one when it was off. Both were intended to look and operate in the same way. Rather than maintain two identical systems, it makes more sense to only have one. This also makes the visual and tab order match for all versions, which is better accessibility too.
jeryj
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
jeryj
added
[Type] Enhancement
|
Size Change: +49 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
alexstine
reviewed
Nov 7, 2023
I swear it had worked before in #54513. I took a look back at that and it was using |
|
@jeryj No luck. I think the toolbar role is likely overriding the announcement but we've got to keep that. 😞 |
jeryj
force-pushed
the
add/top-toolbar-slot
branch
from
57e2f67
to
ea00096
Compare
jeryj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a menubar role to the header bar on the post editor, site editor, and widgets editor when using the top toolbar mode.
Why?
Allows for better semantic groupings of the toolbars.
How?
Adds the
menubarrole to the header if using the top toolbar view.Testing Instructions
All visual and keyboard functionality should match trunk.
Check that the header has a
role="menubar"in the site editor, post editor, and widgets editor.Using a screen reader with the virtual focus on that element should announce that is a menubar.