Templates: Update filter to call all of the individual methods #55980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he last one is being called
|
Size Change: +74 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
glendaviesnz
added
[Type] Bug
glendaviesnz
commented
Nov 8, 2023
| filterCompatiblePatterns | ||
| ( pattern, index, items ) => | ||
| filterOutExcludedPatternSources( pattern ) && | ||
| filterOutDuplicatesByName( pattern, index, items ) && |
There was a problem hiding this comment.
I think any duplicates by name will be removed here, so I wonder if we need this filter?
There was a problem hiding this comment.
Looks like we don't then :)
There was a problem hiding this comment.
This might warrant a deeper look as it's not the only place where duplicates were filtered out by name.
There was a problem hiding this comment.
I think we should limit the scope of this PR to fixing the bug in question and investigate whether the "duplicate by name" filter can be omitted separately.
That filter comes from where block patterns were first merged as part of the site editor settings. There are also several other places the filter could be removed if it is safe for us to do so here. In other words, we should explore it as a follow-up instead. What do you think?
…oved on the server" This reverts commit da8b04f.
I am happy with that approach, have reverted that change. |
|
Flaky tests detected in 83f54c5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6806958601
|
aaronrobertshaw
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the pattern array filter in the site editor template panel hook to call all of the filter methods.
Why?
As noted here, because multiple methods are called this needs to be done within a function, otherwise only the last method is actually being called with the existing syntax.
This didn't show as a bug as in this instance the last filter method is the critical one so with the TT4 templates example this still resulted in the correct list of templates being returned.
How?
Adds a function call to the array.filter call, and executes each of the filter methods in within this function.
Testing Instructions
Screenshots or screencast
swap-pattern-template.mp4