Add hasBlockSelected check when collapsing center header area #56219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the site editor with top toolbar mode on, you could arrive at a state with no block toolbar and no cenntral area. We should only collapse the central area when there is also a block selected.
|
Size Change: +6 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
I can confirm the PR fixes the issue above:
|
DAreRodz
added
[Package] Edit Site
|
Flaky tests detected in 9c7ae35. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7105445003
|
|
The file no longer exists after the "great unification" and I think this issue was resolved via #65839. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@jeryj, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
On the site editor with top toolbar mode on, you could arrive at a state with no block toolbar and no central area. We should only collapse the central area when there is also a block selected.
Why?
The central area was hidden when it should be showing.
How?
Check for
hasBlockSelectedbefore collapsing this area.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast