Patterns: Add a preference to disable the loading the of the choose pattern modal #56307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
@WordPress/gutenberg-design what are your thoughts on adding this preference? |
|
Size Change: -33 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
…es` something is a little odd
|
Flaky tests detected in 065ec2e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6923723591
|
There was a problem hiding this comment.
Thanks for working on this @glendaviesnz 👍
It might be worth noting in the test instructions the pattern selection on new pages is not available in the site editor.
It looks like @talldan has a PR adding this pattern selection to the site editor though (#55117). That will need updating to use this new preference as well.
When testing with TT3, this appeared to only work one time for me. Now, regardless of what my preference setting is I can't get the pattern selection modal back.
Screen.Recording.2023-11-20.at.11.11.27.am.mp4
After switching to TT4, the pattern selection did appear although it takes a long time to show on first load. Toggling the preference back on results in the pattern selection suddenly appearing over the top of the preferences modal. That felt very unexpected to me.
Screen.Recording.2023-11-20.at.11.28.03.am.mp4
talldan
reviewed
Nov 20, 2023
Comment on lines
149
to
152
| 'Enables the choose pattern modal when adding a new page.' | ||
| ) } | ||
| label={ __( 'Enable choose pattern modal' ) } | ||
| /> |
There was a problem hiding this comment.
I think the copy could be tweaked as a lot of users won't know what a modal is.
Something like "Show starter patterns" / "Shows starter patterns when creating a new page.".
|
My instinct: we should not add this preference yet. The flow for creating new pages is still in flux, with the add new page modal in the site editor, some ideas on a pattern assembler discussed across various comments here, not yet having materialized. In that vein, adding this preference now is going to optimize for an interface that's going to already improve. If after having refined those other flows such a preference is still desired, we can definitely add it. |
|
Closing for now based on this comment. |
@jasmussen do you mind clarifying a bit? Are there existing issues/PRs in progress that overlap with this? This came up today in a discussion amongst a few internal developers as being an annoyance, and I feel like it might be worth exploring a bit more. Just curious, thanks! |
|
I should've been clearer and referred to an issue, which is this one: #50739 — "assembler" may be a vernacular that has emerged in varous GH comments across the repo, but it refers to the same. The idea that there is a receded view, or a zoomed-out view, where you build out a page using only patterns. In this context, you cannot edit the content of any blocks, you can only insert and rearrange the patterns, and are literally viewing a scaled down version of the page. Also related to #48456, it's a UI that can potentially unify with the "add new page" template modal as discussed here. The big UI challenge is figuring out how you enter and exit this context from within the editor, or the site view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a preference to disable the loading of the
Choose a patternmodal when adding new pagesWhy?
If experienced users are always wanting to start with a blank page it is a frustrating extra step in their workflow to dismiss this modal each time.
Fixes: #56181
How?
Adds a preference to disable this modal to the editor preferences
Testing Instructions
Choose a patternmodal loadsChoose a patternmodal loads againScreenshots or screencast
choose-pattern-2.mp4