Dataviews: All templates: Add: Sorting to template author and add author_text to the rest API. #56333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/rest-api.php ❔ phpunit/class-gutenberg-rest-templates-controller-test.php |
|
Size Change: +47 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jorgefilipecosta
added
the
[Feature] DataViews
ntsekouras
reviewed
Nov 21, 2023
ntsekouras
reviewed
Nov 21, 2023
packages/edit-site/src/components/page-templates/dataviews-templates.js
Outdated
Show resolved
Hide resolved
ntsekouras
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Thanks for the PR Jorge! I've just skimmed through the code and I definitely agree that this should be done in the REST API layer. I have a few notes though.
I think the endpoint besides the author_text, should be augmented to return the origin type(ex ENUM: user, theme, site, plugin). This could be useful in the codebase to in order to avoid doing the exact same checks again client side. And this leads to my second note, that we should refactor useAddedBy` hook(maybe in a follow up? 🤔 ). Additionally the templates list(data views) use the above hook, so some changes might be needed to use the data from the items now.
Finally since this PR updates PHP, it would be good to add the PHP tests here, to make the backport to core more smooth.
jorgefilipecosta
force-pushed
the
add/sorting-to-template-author
branch
from
42e92e5 to
aaecaa8
Compare
Hi @ntsekouras, I added an original_source field which can be Regarding the backporting in this case it will always be tricky because here we use API to add a new field while in core we will refactor the current endpoint to include the new field natively. The tests created for the plugin would be different from the ones in core, I guess the simplest way to make the backporting of this PR simpler would be to create an equivalent PR to this one in core right now, with the tests and all other required changes. What do you think? Besides the creation of an equivalent core PR backporting the REST API changes and including tests, is there any other change you think we should do before the merge? |
|
Flaky tests detected in aaecaa8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6995573616
|
|
Regarding the tests I was thinking adding here the |
jorgefilipecosta
force-pushed
the
add/sorting-to-template-author
branch
from
aaecaa8 to
f2d4451
Compare
ntsekouras
reviewed
Nov 27, 2023
packages/edit-site/src/components/page-templates/dataviews-templates.js
Outdated
Show resolved
Hide resolved
ntsekouras
reviewed
Nov 27, 2023
ntsekouras
reviewed
Nov 27, 2023
ntsekouras
reviewed
Nov 27, 2023
| 'update_callback' => null, | ||
| 'schema' => array( | ||
| 'type' => 'string', | ||
| 'description' => __( 'Human readable text for the author.' ), |
There was a problem hiding this comment.
I think we need to add the domain gutenberg in __ call. I believe there was a linting rule for that in the past.
ntsekouras
approved these changes
Nov 27, 2023
jorgefilipecosta
force-pushed
the
add/sorting-to-template-author
branch
from
79776c5 to
71eb4de
Compare
18 tasks
getdave
reviewed
Jan 25, 2024
Comment on lines
-134
to
+141
| 'id' => 'emptytheme//my_template', | ||
| 'theme' => 'emptytheme', | ||
| 'slug' => 'my_template', | ||
| 'source' => 'custom', | ||
| 'origin' => null, | ||
| 'type' => 'wp_template', | ||
| 'description' => 'Description of my template.', | ||
| 'title' => array( | ||
| 'id' => 'emptytheme//my_template', | ||
| 'theme' => 'emptytheme', | ||
| 'slug' => 'my_template', | ||
| 'source' => 'custom', | ||
| 'origin' => null, | ||
| 'type' => 'wp_template', | ||
| 'description' => 'Description of my template.', | ||
| 'title' => array( |
There was a problem hiding this comment.
Confirmed that these changes are not backported to Core version of this test file.
|
👋 Hi @jorgefilipecosta. I think the changes to |
|
Confirmed this is happening in WordPress/wordpress-develop#5940 |
youknowriad
added
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the follow-ups on #55848 (comment).
Adds sorting to the template author text field. To make sorting possible, we also add an author_text to the rest API of wp_templates.
Testing
Go to the manage all templates page.
Verify sorting works as expected.