-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor: Shorter screen reader announcement after changing pages #56339
Conversation
Size Change: -55 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some points of discussion added.
291a953
to
2828b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me!
I rebased on top of latest trunk and pushed a commit to clarify a couple translators comments.
Some unrelated End-to-End Tests (Puppeteer ) are continuously failing even after restarting the failing job several times. I've seen these tests failing on other pull requests as well. That's a little annoying :) Does anyone know why these tests fail and if it's a known issue? @youknowriad 🙏 Example: https://github.com/WordPress/gutenberg/actions/runs/7002611856/job/19050455970?pr=56339
|
What?
Partially fixes #56188
Why?
The current title message is very verbose, this PR shortens it.
How?
Adds a dedicated prop for accessibility announcements.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast