Add @react-native-community/netinfo library #56362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7b4f55a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6940993675
|
|
Closing this in favor of using a bridge-based approach to receive the connectivity status directly from the host apps in the editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP: Exploring using
@react-native-community/netinfoto detect connectivity status and displaying basic online/offline notifications in the mobile editor.Note: This may not necessarily be the final structure or implementation of how a native connectivity status component is implemented, but rather a means to implement
@react-native-community/netinfoand how we might go about using it within the existing Editor component hierarchy.Why?
Improve media uploading capabilities in the mobile editor.
How?
@react-native-community/netinfolibraryTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast