Dataviews: Ensure items and fields are using a unique id #56366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
|
Size Change: +49 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 21, 2023
| @@ -5,6 +5,7 @@ This file documents the DataViews UI component, which provides an API to render | |||
| ```js | |||
| <DataViews | |||
| data={ pages } | |||
| getItemId={ ( item ) => item.id } | |||
There was a problem hiding this comment.
I'm hesitant to make this a separate prop or a special field but this works for me. We can see over time.
There was a problem hiding this comment.
Also, should we document the prop?
There was a problem hiding this comment.
Let's do the documentation in a follow up and add more info on the other props too.
youknowriad
approved these changes
Nov 21, 2023
|
Flaky tests detected in 7dda6db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6942272625
|
ntsekouras
deleted the
update/dataviews-to-use-stable-item-and-field-ids
branch
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds an
getItemIdprop to DataViews component to ensure we're using unique ids and notindexesas keys, to avoid rerendering when it's possible.Right now the data we're rendering are not expensive, but this will help in the long run, when we have such, like previews etc..
If
getItemIdis not provided, it fallbacks to indexes as it's on trunk right now.Testing instructions