Site Editor: Add the Post Author component to the Page sidebar #56368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
commented
Nov 21, 2023
| @@ -18,7 +22,7 @@ export default function PageSummary( { | |||
| postType, | |||
| } ) { | |||
| return ( | |||
| <VStack> | |||
| <VStack spacing={ 0 }> | |||
There was a problem hiding this comment.
This small change is independent but it just removes the spacing between the different controls to match the post editor.
youknowriad
commented
Nov 21, 2023
| ) } | ||
| <div className="editor-post-panel__row-control">{ children }</div> |
There was a problem hiding this comment.
The change here is a simplification that also makes the "pending" toggle look better spaced in the post editor.
|
Size Change: +47 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Working for me 👍 
It might be nice to use the same format as the other summary details, IE: 
Appreciate if that's something to handle separately though. |
jameskoster
approved these changes
Nov 21, 2023
|
I agree, I don't like the design that looks so different. But I'm going to leave that for a separate issue/person probably. I'd like to move forward with more unification of existing stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR adds the "post author" control from the post editor to the site editor sidebar. The goal is to ultimately bridge the gap between these two editors and just merge them.
Testing Instructions
1- Open a page in the site editor.
2- Notice that you can change the author from the sidebar.