Move the DisableNonContentBlocks component to the editor package #56423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: -2 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
Since the site editor is now using the "mode" prop from the EditorProvider to indicates how to render the page/template, it should be part of the responsibility of the EditorProvider to lock/unlock blocks depending on this mode. This PR does just that by moving the
DisableNonContentBlocksto theEditorProvider.Ultimately, this will allow us to actually use the same template/editor modes in the site and post editors.
Testing Instructions
1- Just make sure that the site editor for editing pages continue to work as expected: templates locked by default and you can switch...