Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use allow-list for mobile editor settings endpoint #56424

Draft
wants to merge 11 commits into
base: trunk
Choose a base branch
from
Draft

Use allow-list for mobile editor settings endpoint #56424

wants to merge 11 commits into from

Commits on Nov 22, 2023

  1. Use allow-list for mobile editor settings endpoint

    @mkevins
    mkevins committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    16e6185 View commit details
    Browse the repository at this point in the history

  2. refactor: Format php 

    Address linter errors and warnings.
    @dcalhoun
    dcalhoun committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f65e77a View commit details
    Browse the repository at this point in the history

  3. refactor: Guard mobile allow list utility against redeclaration 

    Address linter error.
    @dcalhoun
    dcalhoun committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    df2b3d5 View commit details
    Browse the repository at this point in the history

  4. fix: Avoid error from selecting non-existent settings key 

    If the settings do not include an item listed in the allow list, we must
avoid an attempt to reference the non-existent settings key.
    @dcalhoun
    dcalhoun committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3e4a8c1 View commit details
    Browse the repository at this point in the history

  5. fix: Add __experimentalStyles key to the allow list 

    This appears to be expected by the existing tests. However, it is
unclear if all or a subset of the nested keys are expected or required.
    @dcalhoun
    dcalhoun committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a4995db View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Rename mobile settings allow-list filter function

    @mkevins
    mkevins committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8f072e3 View commit details
    Browse the repository at this point in the history

  2. Extract mobile editor settings allow list to a constant

    @mkevins
    mkevins committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    7f3d705 View commit details
    Browse the repository at this point in the history

  3. Remove experimental dashboard link from the mobile allow list

    @mkevins
    mkevins committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9c19187 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Extract mobile editor settings filter to a separate file 

    The important part of this is that the filter is a separate filter.
Incidentally, this also fixes a bug in which the previous draft
implementation returned a filtered response even for non-mobile
contexts.
    @mkevins
    mkevins committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    ce92b82 View commit details
    Browse the repository at this point in the history

  2. Load mobile-specific filter for the editor settings endpoint

    @mkevins
    mkevins committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    0a1e7bd View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. refactor: Format php 

    Appease linter errors via `npm run format:php`.
    @dcalhoun
    dcalhoun committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a7cb39f View commit details
    Browse the repository at this point in the history