Disable block renaming support for Nav Link block #56425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
getdave
requested review from
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
getdave
force-pushed
the
fix/no-renaming-for-nav-item-blocks
branch
from
7302a39
to
370b31c
Compare
|
Trying a rebase here to see it clears the unusual test results (potentially anomalous). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disables the ability to rename the Navigation Link block.
Closes #56155
Closes #55643
Why?
It doesn't make sense in this context.
How?
Set
renamingblock support to `false.Testing Instructions
Renameis not shown as an option.Testing Instructions for Keyboard
Screenshots or screencast