Update Readme.txt tested up to 6.4 #56427
Conversation
bph
added
[Type] Bug
| @@ -141,7 +141,7 @@ For example, running the `start` script from inside the generated folder (`npm s | |||
|
|
|||
| ## External Project Templates | |||
|
|
|||
| [Click here](https://developer.wordpress.org/block-editor/reference-guides/packages/packages-create-block-tutorial-template/) for information on External Project Templates | |||
| [Click here](https://developer.wordpress.org/block-editor/reference-guides/packages/packages-create-block/packages-create-block-external-template/) for information on External Project Templates | |||
There was a problem hiding this comment.
It doesn't look relevant based on the PR's description, but it's a good change we can include.
There was a problem hiding this comment.
A I seem to have goofed this simple thing... how do I remove that file?
There was a problem hiding this comment.
Curious. This change was already merged in #56106, but it's not harmful to do it again
|
Just noting that this PR had an impact on the performance job, it now started failing on trunk. In general when we update the "Tested up to", I think we should probably change the "base" commit used for performance jobs. |
|
It looks like after 352ab99, there are the same fatal errors reported. Can you explain how a change in the readme file impacts the performance job so we could document it? |
|
The "Tested up to" flag is used as a "base WordPress version" for the docker containers that are used in the performance jobs. The reason is that the performance jobs compare current commit with an old commit and upon release, the compare current release with WP version - 1. So the WP version need to be one that is older than WP version - 1 but it also need to be one that is supported by the Gutenberg plugin today. |
|
That said, I'm not out of ideas about the current failure, we need to debug further. |
|
That's super interesting to learn. Good luck troubleshooting this. 🤗 |
What?
Update the version in "Tested up to" section of the readme.txt of the plugin to the latest WordPress version.
Why?
To avoid the "This plugin hasn't been tested for your current version of WordPress" banner in the plugin repo and plugin workflow on WPAdmin