Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add the attributes definition page to the create block tutorial of the platform docs #56429

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Documentation: Add the attributes definition page to the create block tutorial of the platform docs #56429

merged 2 commits into from
Nov 22, 2023

Conversation

youknowriad
Copy link
Contributor

Related #53874

What?

This is the second page of the "create block type" tutorial on the "Gutenberg as framework" documentation website.

You can check the current state of the website locally by doing:

cd platform-docs
npm install
npm start

@youknowriad youknowriad added the [Type] Developer Documentation Documentation for developers label Nov 22, 2023
@youknowriad youknowriad requested a review from a team November 22, 2023 11:02
@youknowriad youknowriad self-assigned this Nov 22, 2023
@youknowriad youknowriad requested review from talldan and gziolo and removed request for a team November 22, 2023 11:02
priethor
priethor approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of formatting and readability suggestions; feel free to accept or discard them at your discretion 👍

platform-docs/docs/create-block/attributes.md Outdated Show resolved Hide resolved
platform-docs/docs/create-block/attributes.md Outdated Show resolved Hide resolved
platform-docs/docs/create-block/attributes.md Outdated Show resolved Hide resolved
@youknowriad @priethor
Changes per review.
fb9a546 
Co-authored-by: Héctor <27339341+priethor@users.noreply.github.com>
@youknowriad youknowriad enabled auto-merge (squash) November 22, 2023 13:35
@youknowriad youknowriad merged commit f73f8d2 into trunk Nov 22, 2023
49 checks passed
@youknowriad youknowriad deleted the docs/add-attributes-tutorial-page branch November 22, 2023 14:03
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priethor priethor priethor approved these changes

@talldan talldan Awaiting requested review from talldan talldan was automatically assigned from WordPress/gutenberg-core

@gziolo gziolo Awaiting requested review from gziolo gziolo was automatically assigned from WordPress/gutenberg-core

Assignees

@youknowriad youknowriad

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 17.2
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @priethor