Block Settings: Only display parent block selector on small screens #56431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
draganescu,
jasmussen and
richtabor
and removed request for
ellatrix
|
Size Change: +33 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Nov 22, 2023
| // Allows highlighting the parent block outline when focusing or hovering | ||
| // the parent block selector within the child. | ||
| const menuItemRef = useRef(); | ||
| const gesturesProps = useShowHoveredOrFocusedGestures( { |
There was a problem hiding this comment.
When would this be triggered on a touch screen?
There was a problem hiding this comment.
I've not tested on touch screens, but it should highlight the block when a menu item is hovered or focused.
I just changed variable names; the functionality is the same.
draganescu
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
This makes sense otherwise on mobile it's hard to go up to parent in the visual editor w/o list view being invoked, which also hides the content.
Just noting that once #52032 is wrapped we can remove the select parent from this menu on mobile as well, b/c then the parent selector will live in the block toolbar.
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #50443.
PR updates rendering logic for parent selector menu item in the Block Options dropdown. Now it's only rendered when the toolbar button with the same functionality isn't displayed - on small screens.
Now it's only rendered on smaller screens when the parent selector in the Block Toolbar isn't visible.
Why?
See discussion in #50443.
How?
I've moved most of the logic into the
ParentSelectorMenuItemcomponent, which will bail out rendering based on the screen size.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2023-11-22.at.15.21.53.mp4