Preview: Unset popup window upon close #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
jorgefilipecosta
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5634
This pull request seeks to resolve an issue where previewing, closing the preview, and then proceeding to update a post in Firefox will cause the editor to crash. This is because we attempt to set the preview popup window to the updated URL if it is still open after the post is updated:
gutenberg/editor/components/post-preview-button/index.js
Lines 44 to 45 in ba7159e
This issue primarily impacts Firefox, where the window reference of
this.previewWindowstill exists even after the popup has been closed. The changes here resolve the issue by ensuring that the value is unset if the popup is closed.Testing instructions:
Repeat testing instructions from #5634 . Note that the error would only have occurred when, after step 2, you return to the post by closing the popup window. This should work in both Firefox and in your preferred browser.