Migrate 'custom taxonomies' e2e test to Playwright #56486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
Co-authored-by: Alvi Tazwar <55917380+alvitazwar@users.noreply.github.com>
Mamaduka
force-pushed
the
migrate/custom-taxonomies-e2e-test
branch
from
b8503dd
to
513de34
Compare
WunderBart
reviewed
Nov 24, 2023
Comment on lines
+33
to
+38
| // Open the panel if needed. | ||
| if ( | ||
| ( await modelPanel.getAttribute( 'aria-expanded' ) ) === 'false' | ||
| ) { | ||
| await modelPanel.click(); | ||
| } |
There was a problem hiding this comment.
Is this another example of the global state bleed when running tests in parallel?
There was a problem hiding this comment.
This doesn't solve the persisted state issue, but maybe we should introduce the openDocumentSettingsPanel helper and hide implementation details there.
WunderBart
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Supersedes and closes #45178.
PR migrates sidebar-permalink.test.js e2e test to Playwright.
Why?
See #38851.
How?
The migration is based on #45178, which I think is abandoned. I've included the author so they get credit for their contribution.
Testing Instructions