Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme.json: Extend block style variations support #56540

Closed
wants to merge 25 commits into from

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    a65a9f5 View commit details
    Browse the repository at this point in the history
  2. Extend theme.json schema for extended block style variations

    Block style variations can now also contain inner block type and element styles. Currently the inner block styles are not recursive in that they do not support nested style variations.
    aaronrobertshaw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8da9d1f View commit details
    Browse the repository at this point in the history
  3. Update PHP processing of block style variations in theme.json

    Includes:
    - absorbing block style variations from the block styles registry into theme.json
    - updating metadata and stylesheet generation from variations to support inner block and element styles
    aaronrobertshaw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    01d1843 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    883c467 View commit details
    Browse the repository at this point in the history
  5. Allow non-core block style variations to be configured within Global …

    …Styles
    
    This initial approach will restrict the block style variations configurable within Global Styles to core block styles and those registered and possessing matching styles within the base theme.json.
    aaronrobertshaw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5f17722 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a4d54d6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e5b5196 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b66a1cb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4744dc3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1130551 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d49e029 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7582c5f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7426a3d View commit details
    Browse the repository at this point in the history
  14. Bump block instance elements specificity

    Think change is still up for debate. If accepted it may be a breaking change that needs plenty of communication.
    aaronrobertshaw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f48dd57 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c47aa41 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9aca87e View commit details
    Browse the repository at this point in the history
  17. Bump element styles specificity again for overcoming variation styles

    This ensures that element styles placed upon a block instance by the user take precedence over element styles for a block type within a block style variation e.g. `styles.blocks.core/group.variations.custom.blocks.core/media-text.elements`
    aaronrobertshaw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a003477 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    562a9fa View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Revert "Bump element styles specificity again for overcoming variatio…

    …n styles"
    
    This reverts commit a003477.
    aaronrobertshaw committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    f09833f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29180f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6413ecd View commit details
    Browse the repository at this point in the history
  4. Revert "Add element styles for inner blocks within a variation to sit…

    …e editor"
    
    This reverts commit 562a9fa.
    aaronrobertshaw committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    4f56178 View commit details
    Browse the repository at this point in the history
  5. Revert "Reinstate processing of variation > block > elements in block…

    … node generation"
    
    This reverts commit 9aca87e.
    aaronrobertshaw committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    f092ad7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    15270b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    6fb1cfb View commit details
    Browse the repository at this point in the history