QueryControls: Add opt-in prop for 40px default size
#56576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
|
The RangeControl in QueryControls already has the prop enabled: gutenberg/packages/components/src/query-controls/index.tsx Lines 178 to 180 in 05dcf4b Would we want to set all to true for consistency instead of making it opt-in? Or make RangeControl optional? |
|
I would pass the |
ciampo
reviewed
Nov 29, 2023
brookewp
force-pushed
the
add/40pxsize-querycontrols
branch
from
8d12693 to
ccf62e9
Compare
brookewp
force-pushed
the
add/40pxsize-querycontrols
branch
from
ccf62e9 to
be58b48
Compare
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* `QueryControls`: Add opt-in prop for 40px default size * Update RangeControl 40px size to be opt-in * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
Add a new opt-in prop
__next40pxDefaultSizeto QueryControls, following the plan outlined in above mentioned PR.Why?
For more consistency in styling.
How?
A new, temporary
__next40pxDefaultSizeprop. When the prop is set totrue, the inputs will have a height of 40px.Testing Instructions
In Storybook:
npm run storybook:dev__next40pxDefaultSizetotruefor QueryControlsIn the editor
Smoke test the component in the editor; QueryControls shouldn't have any visible changes for now.