Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global style revisions: show change summary on selected item #56577

Merged
merged 21 commits into from
Dec 12, 2023
Merged

Global style revisions: show change summary on selected item #56577

merged 21 commits into from
Dec 12, 2023

Commits on Dec 7, 2023

  1. Moving date format setting call into the comoponent 

    rejigging getLabel function
adding css var
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    707b75e View commit details
    Browse the repository at this point in the history

  2. Testing a message to indicate that the revisions state is the same as… 

    … the editor state.
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    cab578a View commit details
    Browse the repository at this point in the history

  3. Working on change list, adding translations. WIP

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6e0bfca View commit details
    Browse the repository at this point in the history

  4. Adding more translations.

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b29086c View commit details
    Browse the repository at this point in the history

  5. Revert button-in-item for another day 

    Reduce depth of changeset and remove unused translations
Display aria-label on button instead of tooltip
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    78ee1c5 View commit details
    Browse the repository at this point in the history

  6. Removing shuffle function and fixing up block spacing translation

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a31cd2a View commit details
    Browse the repository at this point in the history

  7. Using the revision has the Map key. This allows us to cache the revis… 

    …ion sets themselves and account for changes to Unsaved revisions.
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d27d6c0 View commit details
    Browse the repository at this point in the history

  8. Used WeakMap in favour of Map for garbage collection, if it helps at all

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    087084d View commit details
    Browse the repository at this point in the history

  9. Remove hasMore var - unneeded because it's only used once

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    dcca429 View commit details
    Browse the repository at this point in the history

  10. Tidying up - remove .map loop

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    23a2615 View commit details
    Browse the repository at this point in the history

  11. getGlobalStylesChanges was doing nothing! Removed.

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    803c4d9 View commit details
    Browse the repository at this point in the history

  12. Using revision + previousRevision combo for cache key to ensure that … 

    …the results are cached for the same two objects

Returning from cache where maxResults value is smaller than cached results
Added first tests
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0d2d425 View commit details
    Browse the repository at this point in the history

  13. Moving maxResults decisions to consuming component. getRevisionChange… 

    …s returns an unadulterated array.
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    fe76b98 View commit details
    Browse the repository at this point in the history

  14. Move get blockNames to main component

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    c070f9f View commit details
    Browse the repository at this point in the history

  15. Have to use map because WeakMap wants the same reference as the objec… 

    …t key.
    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    776094e View commit details
    Browse the repository at this point in the history

  16. Remove the trailing comma on truncated results

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f53ce53 View commit details
    Browse the repository at this point in the history

  17. Test commit: listing changes, showing and n more

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d5dd7e7 View commit details
    Browse the repository at this point in the history

  18. Test commit: grouping changes using tuples

    @ramonjd
    ramonjd committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ec31842 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Reverting back to comma-separate list of changes 

    Added e2e assertion
    @ramonjd
    ramonjd committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    fde41c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Swapping order of author name and changes block 

    Moving everything into the button so it's clickable.
    @ramonjd
    ramonjd committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    559cd3e View commit details
    Browse the repository at this point in the history

  2. Don't live in the past, man

    @ramonjd
    ramonjd committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    25b8a15 View commit details
    Browse the repository at this point in the history