Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try improving the side UI for nested blocks #5658

Merged
merged 12 commits into from
Apr 2, 2018
Merged

Try improving the side UI for nested blocks #5658

merged 12 commits into from
Apr 2, 2018

Commits on Apr 2, 2018

  1. Improve nested blocks UI 

    This PR is very much a work in progress. Pushing now early, so I can work on it both at work and at home. It will not even be made a PR yet, and with a good squash there's every chance you won't even read this message. Github squashing is like Terminator time travel!
    @aduth
    Joen Asmussen authored and aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    ca0a129 View commit details
    Browse the repository at this point in the history

  2. Block List: Show insertion point prior to block 

    Better compatibility with high z-index of sibling inserter conflicting with hover behavior of block.
    @aduth
    aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    2e84923 View commit details
    Browse the repository at this point in the history

  3. Block List: Show block breadcrumb prior to block

    @aduth
    aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    9b1922e View commit details
    Browse the repository at this point in the history

  4. Editor: Expose BlockTitle component

    @aduth
    aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    e7e9286 View commit details
    Browse the repository at this point in the history

  5. Undo the pointer-events trick.

    @aduth
    Joen Asmussen authored and aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    3139bdf View commit details
    Browse the repository at this point in the history

  6. Block List: Cancel hover on handled descendant mouseover

    @aduth
    aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    ceae698 View commit details
    Browse the repository at this point in the history

  7. Fix arrow border and pixel shift. 

    Fix issue with nesting when only one block present on the movers. Props @paulwilde.

Fix issue with separator and pullquote pixelshifting on hover. Turns out this was due to collapsing margins, and iffy rounding that happened when a new toolbar was present. For now I prevented margins from collapsing on those, but this should be revisited and refactored separately.
    @aduth
    Joen Asmussen authored and aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    f6bed23 View commit details
    Browse the repository at this point in the history

  8. Fix issues with wide and fullwide 

    This fixes a few issues with wide and fullwide alignments. Props for reporting, @jvisick.

- Movers now work on wide and fullwide, and look good
- Hovering now both works without horizontal scrollbars on wide items, and they aren't overlapped by the movers
- Wide alignment blocks now don't have negative margin to accommodate side UI.
    @aduth
    Joen Asmussen authored and aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    95c7353 View commit details
    Browse the repository at this point in the history

  9. Improve side UI for fullwide. 

    Props for bugtesting, @jvisick

This adds padding left and right on fullwide columns. We can revisit this in the future.
    @aduth
    Joen Asmussen authored and aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    15380d5 View commit details
    Browse the repository at this point in the history

  10. Improve the appender inside columns, so it's the same UI as it is on … 

    …mobile.
    @aduth
    Joen Asmussen authored and aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    cee70e6 View commit details
    Browse the repository at this point in the history

  11. Testing: Click at rightish of between inserter

    @aduth
    aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    f67884c View commit details
    Browse the repository at this point in the history

  12. Block List: Assign mover z-index via map entry

    @aduth
    aduth committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    e1336d3 View commit details
    Browse the repository at this point in the history