Migrate 'block directory' e2e tests to Playwright #56593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: +120 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
WunderBart
approved these changes
Nov 28, 2023
Comment on lines
+238
to
+241
| await expect( downloadableBlock ).toBeVisible(); | ||
|
|
||
| // Install the block. | ||
| await downloadableBlock.click(); |
There was a problem hiding this comment.
Since clicking the element implies visibility, can we skip the visibility check?
There was a problem hiding this comment.
Don't have a strong opinion here. It is just a personal translation for an action sequence - search, confirm the item is visible, and click on it 😄
Btw, our guide also suggests explicit assertions - https://developer.wordpress.org/block-editor/contributors/code/testing-overview/e2e/#make-explicit-assertions
cc @kevin940726
There was a problem hiding this comment.
If the visibility check is part of what we want to test then I'd say explicit assertion is often better. In cases where it fails then we get a nicer error message on that line rather than an implicit error when trying to click on it. On the other hand, if checking the visibility isn't the focus of the test (maybe some other tests did it), then we can skip the visibility check 👍.
Co-authored-by: Bart Kalisz <bartlomiej.kalisz@gmail.com>
Mamaduka
force-pushed
the
migrate/block-directory-e2e-tests
branch
from
32530b5
to
6e6231e
Compare
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Migrate 'block directory' e2e tests to Playwright * Remove old test files * Skip class locators. Co-authored-by: Bart Kalisz <bartlomiej.kalisz@gmail.com> * Simplify the last assertion --------- Co-authored-by: Bart Kalisz <bartlomiej.kalisz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates the
block-directory-add.test.jse2e test to Playwright. I've also changed the test name into a more generalblock-directoryWhy?
See #38851.
Testing Instructions