Scripts: Enable skipping Playwright browser installation #56594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
WunderBart
added
the
[Type] Automated Testing
|
Size Change: +55 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Nov 28, 2023
Good point. How should this be handled in such a case? |
|
I think @swissspidy was suggesting an opt-out flag for Maybe something like |
kevin940726
approved these changes
Nov 29, 2023
Comment on lines
+33
to
+37
| path.resolve( | ||
| require.resolve( 'playwright-core' ), | ||
| '..', | ||
| 'cli.js' | ||
| ), |
There was a problem hiding this comment.
Off-topic: This is probably an implementation detail, I wonder why we don't just use npx here?
There was a problem hiding this comment.
I tried swapping it here but couldn't get it working locally - #54051 (comment).
There was a problem hiding this comment.
Yeah I recall seeing this earlier but couldn't remember where 😆.
There was a problem hiding this comment.
It seems to be working for me via:
const result = spawn( 'npx', [ 'playwright', 'install' ], {
stdio: 'inherit',
} );
Big +1 to this. There are other projects outside core & Gutenberg relying on However, a flag like I suggested will give us more flexibility here. So I would suggest doing that instead. |
|
We could also use a new env variable. Puppeteer has |
The issue with this approach is apparently that it would need to be passed like this: ...which makes it a part of the test runner args, which breaks it because it doesn't recognize that arg. We could probably filter it out from those args, but it feels like an anti-pattern since the only utils we have are getters around note: Just noticed your comment about |
It also supports it for Node, see https://github.com/microsoft/playwright/blob/1901a1a1555536e26beb74c77695a866b501f27f/docs/src/library-js.md#browser-downloads While it's only meant for |
WunderBart
force-pushed
the
fix/playwright-browser-deps
branch
from
31c881d to
c9d6bae
Compare
WunderBart
changed the title
Updated in c9d6bae! |
|
@swissspidy, it looks like these would need to be updated as well unless there's still some stuff running with Puppeteer: |
Unfortunately there still is 😞 QUnit tests in WP use Puppeteer |
swissspidy
reviewed
Nov 29, 2023
| stdio: 'inherit', | ||
| } | ||
| ); | ||
| if ( process.env.PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD !== '1' ) { |
There was a problem hiding this comment.
Should we also check for 'true'?
There was a problem hiding this comment.
Good point. I figured I'd find a util for that (getting env vars as boolean values), but there doesn't seem to be one. Decided to add it and make it convert just like Playwright does it. Updated in c290701.
swissspidy
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #56588
Dependencies in CI should be explicitly defined for the sake of saving time. For example, performance tests only run against Chromium, but all browsers are installed anyway because we're running
playwright installbefore each test run. Adding aCIcheck should be sufficient to address this.To make sure we're not breaking anything, I've checked the following workflows to ensure they install Playwright deps explicitly:
Testing Instructions
node packages/scripts/node_modules/playwright-core/cli.js uninstallCIvar added:CI=true npm run test:e2e:playwrightnpm run test:e2e:playwright