Block library: reusable caption component util #56606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
artemiomorales,
michalczaplinski,
geriux and
ajitbohra
as code owners
|
Size Change: +513 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
commented
Nov 28, 2023
| if ( ! isSelected && ! caption ) { | ||
| setShowCaption( false ); | ||
| } | ||
| }, [ isSelected, caption ] ); |
There was a problem hiding this comment.
Note that I've also optimised these useEffect and useCallback calls. Previously these callbacks would get called whenever you type in the caption, now they're only called if emptiness changes.
dmsnell
reviewed
Nov 28, 2023
jsnajdr
reviewed
Mar 20, 2024
| import { createBlock, getDefaultBlockName } from '@wordpress/blocks'; | ||
|
|
||
| export function Caption( { | ||
| key = 'caption', |
There was a problem hiding this comment.
Can this really be used to make <Caption> edit an attribute other than caption? key or ref is a reserved prop, React won't really pass it down to the component. Let's find a better name for the prop.
There was a problem hiding this comment.
It was just an unfinished idea. See #59073
There was a problem hiding this comment.
Nice, I see it's all fixed there 👍
| placeholder={ placeholder } | ||
| value={ caption } | ||
| onChange={ ( value ) => | ||
| setAttributes( { caption: value } ) |
There was a problem hiding this comment.
Should be setAttributes( { [ key ]: value } ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prep work for #43204
This is the same logic used by the Image, Gallery, Audio, and Video blocks. Let's make it reusable because it's a pain to change every instance.
Note that I've also optimised these
useEffectanduseCallbackcalls. Previously these callbacks would get called whenever you type in the caption, now they're only called if emptiness changes.Additionally emptiness checks check the length.
Why?
See #43204 (comment)
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast