Migrate 'block icons' e2e tests to Playwright #56610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mimi <mimitips@gmail.com>
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
commented
Nov 28, 2023
| @@ -55,7 +55,7 @@ | |||
| } ); | |||
|
|
|||
| registerBlockType( 'test/test-dash-icon', { | |||
| title: 'TestDashIcon', | |||
| title: 'TestSimpleDashIcon', | |||
There was a problem hiding this comment.
This change prevents name collision. The exact match wasn't enough for some reason 🤷♂️
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Migrate 'block icons' e2e tests to Playwright Co-authored-by: mimi <mimitips@gmail.com> * Remove old test file --------- Co-authored-by: mimi <mimitips@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Supersedes and closes #55501.
PR migrates
block-icons.test.jse2e test to Playwright.Why?
See #38851.
How?
I've collapsed the
test.descriptiongroups into a single test since they can run on the same page. This should remove a few seconds from the whole test runtime.Testing Instructions