FormToggle: do not use "/" math operator #56672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
|
Probably there's no need for a CHANGELOG entry, if this is part of the same Gutenberg release. |
jasmussen
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Green check from me, but I saw a comment by @andrewhayward so I'll defer to him if he prefers another path forward.
|
Yup, Andrew suggested a cleaner solution — just updated the PR to implement his suggestion |
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 9cc302f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7044611846
|
I'm not overly concerned which approach we use, but going the recommended route is probably better for future-proofing.
Agreed. Do we ever tack two PRs together in the same CHANGELOG entry? Would at least make it clear that they're both relevant. |
|
Thanks for the quick follow-up! 🙇 |
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* FormToggle: do not use "/" math operator * Use math.div * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
FormToggle's styles away from using the/math operatorWhy?
As flagged in #56515 (comment), the
/operator is deprecated in SassHow?
Using the
mathmodule and themath.divoperator (as suggested here)Testing Instructions
FormTogglerenders correctly in Windows High Contrast Mode