Make the custom CSS validation error message accessible #56690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -70 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eb4d92a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7048535538
|
…m-css-validation-error-message
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SergeyBiryukov
approved these changes
Feb 13, 2024
|
Thanks everyone for your feedback and review. |
|
Should we backport this to WordPress 6.5? |
|
@youknowriad I wasn't planning to ask beckporting it but if that's possible yes, it would be welcomed. |
|
I think it's a good fix to have and we're still early in the beta cycle, let's add it. |
|
Would love a fact check from designers @jasmussen @jameskoster @SaxonF |
|
Now that the textarea is full-height I tend to agree it was easy to miss the icon in the bottom right. Especially on larger screens. That could have been helped by setting a red border on the textarea too, but I don't suppose that would address the a11y concerns. Given this is a low-traffic area, and hopefully errors are few and far between, a notice seems a reasonable interim despite the rough appearance. I'm not sure it should be dismissible though? |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 79dffd9 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56437
This PR changes the custom CSS validation error message to make it accessible. On top of that, I'd like to add a few considerations:
componentspackage. Only by doing that the new component would be guaranteed to be consistent, reusable, tested, and accessible.What?
The custom CSS validation error message is not accessible. It is also a unique UI in the editor, there's no other usage of a red icon with tooltip and I'd argue it's am unexpected pattern for users.
Why?
Any user-input validation message must be accessible.
How?
Replaces the current implementation based on a red icon plus tooltip with the standard Notice component.
assertivepoliteness level.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before and after: