Core data revisions: remove hardcoded supports constant #56701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to determine revisions support
ramonjd
added
[Type] Code Quality
7 tasks
ramonjd
changed the title
|
Size Change: -35 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
This is all testing well for me across each of the post types, with correct responses when expected for getRevisions and getRevision (with the total items still passed in correctly) and no issues when making invalid calls (responses from the selector are null as expected). Nice job reducing it down to bailing on a failed API request so we can skip the hard-coded list! LGTM ✨
ramonjd
deleted the
update/core-data-remove-hard-coded-revisions-supports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to:
Part of:
What?
This PR:
POST_TYPES_WITH_REVISIONS_SUPPORTconstant in Core Data entities in order to let the server deal with permissionsapiFetchin a try/catch and only dispatch a response if there is one.Why?
So far, we've been duplicating post type revisions support in a
POST_TYPES_WITH_REVISIONS_SUPPORTconstant.This removes that maintenance burden.
How?
Testing Instructions
Check that
getRevision(s)works for supported post types.Example:
See the test descriptions in #56353 for other supported post types.
Test with some invalid API calls, e.g.,