BorderControl: Fix button styles
#56730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
ciampo
reviewed
Dec 4, 2023
Great catch! I was thinking of adding Updated this in 602a3f4 |
brookewp
force-pushed
the
fix/bordercontrol-button
branch
from
602a3f4
to
ddac6ed
Compare
|
Flaky tests detected in 2d45a2a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7135425110
|
chad1008
approved these changes
Dec 7, 2023
brookewp
force-pushed
the
fix/bordercontrol-button
branch
from
fe8b8af
to
2d45a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The size of the button in BorderControl did not match the input field so there is a slight gap between their borders. This also affects BorderBoxControl.
Why?
It looks nicer. :)
How?
Removing the hardcoded height and width, adding an aspect-ratio of 1, and using
size="small"instead of the deprecatedisSmallfor button.Testing Instructions
Ensure BorderControl and BorderBoxControl's borders and size look correct.
Screenshots or screencast
BorderControl
BorderBoxControl