Move mobile ImageLinkDestinationsScreen from components package to block-editor package #56775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock-editor package
derekblank
added
[Type] Code Quality
|
Size Change: +326 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
dcalhoun
approved these changes
Dec 5, 2023
| @@ -11,13 +11,12 @@ import { __ } from '@wordpress/i18n'; | |||
| import { Icon, check, chevronRight } from '@wordpress/icons'; | |||
| import { blockSettingsScreens } from '@wordpress/block-editor'; | |||
There was a problem hiding this comment.
My perception is that the project generally prefers importing internal dependencies. We could change this to a local import now that this file resides within the block-editor package.
Comment on lines
4
to
8
| import { | ||
| InspectorControls, | ||
| ImageLinkDestinationsScreen, | ||
| useMultipleOriginColorsAndGradients, | ||
| } from '@wordpress/block-editor'; |
There was a problem hiding this comment.
I realize some of these imports were already in place, but my perception is that the project generally prefers importing internal dependencies. We could technically change these to local imports.
Comment on lines
+1
to
+16
| // used in both light and dark modes | ||
| .placeholderTextColor { | ||
| color: #87a6bc; | ||
| } | ||
|
|
||
| .optionIcon { | ||
| color: $blue-50; | ||
| } | ||
|
|
||
| .optionIconDark { | ||
| color: $blue-30; | ||
| } | ||
|
|
||
| .unselectedOptionIcon { | ||
| opacity: 0; | ||
| } |
There was a problem hiding this comment.
It appears these selectors in the original stylesheet are now unused and can be removed. Note that .linkSettingsPanel remains in use.
| @@ -91,6 +91,7 @@ export { default as DefaultBlockAppender } from './default-block-appender'; | |||
| export { default as __unstableEditorStyles } from './editor-styles'; | |||
| export { default as Inserter } from './inserter'; | |||
| export { default as InserterButton } from './inserter-button'; | |||
| export { default as ImageLinkDestinationsScreen } from './image-link-destinations'; | |||
There was a problem hiding this comment.
Given this component is only used within the block-editor packages, we should likely consider it private and not export it. WDYT?
Note: in making it private, we would need to import it via a relative path.
|
@dcalhoun Thanks for the review. I agree updating the imports would be more consistent, and I've done so. Would you be able to take another quick look to verify? |
|
Flaky tests detected in 7ccd625. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7110581764
|
dcalhoun
approved these changes
Dec 6, 2023
| import styles from './style.scss'; | ||
| import PanelBody from '../../panel/body'; | ||
| import BottomSheet from '../bottom-sheet'; | ||
| import styles from './style.native.scss'; |
There was a problem hiding this comment.
If I am not mistaken, we are not required to explicitly add the native suffix. I'm not requesting it be changed here (and re-tested), but merely sharing knowledge.
Suggested change
| import styles from './style.native.scss'; | |
| import styles from './style.scss'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the mobile
ImageLinkDestinationsScreenfrom the components package to the block-editor package.Related PRs:
Why?
There is an ongoing effort to remove block-editor package dependencies in native files from the components package in order to eliminate cyclic dependencies:
block-editorpackage in native files within thecomponentspackage #52692How?
Moves code and code references to
ImageLinkDestinationsScreenfrom the components package to the block-editor package.Testing Instructions