DataViews: implement NOT IN operator for author filter in templates
#56777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Experimental
|
Size Change: +14 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 5, 2023
|
Flaky tests detected in 1d01675. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7097998152
|
ntsekouras
reviewed
Dec 5, 2023
| @@ -266,6 +267,14 @@ export default function DataviewsTemplates() { | |||
| filteredTemplates = filteredTemplates.filter( ( item ) => { | |||
| return item.author_text === filter.value; | |||
| } ); | |||
| } else if ( | |||
There was a problem hiding this comment.
We could simplify though the conditions here, but it's fine for now that we are iterating so much..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
Implement the new
NOT INoperator in the author filter for the templates page.Gravacao.do.ecra.2023-12-05.as.09.21.45.mov
Why?
The filter component gained a new
NOT INoperator that is enabled by default. We should either disable it or implement it – right now, the operator is displayed in the filter UI, but it does nothing.How?
Filter templates whose author is not the given one, if the filter uses a
NOT INoperator.Testing Instructions