Block editor: hooks: subscribe only to relevant attributes #56783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +39 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa27a8b857f5a9f15a7763bc6c2a0a2b9d1e8266. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7103462430
|
ellatrix
force-pushed
the
try/subscribe-block-attribute-hooks
branch
from
fa27a8b to
4825492
Compare
ellatrix
changed the base branch from
try/fix-tools-panel-re-renders
to
trunk
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR depends on #56770 to see the improvement better, but otherwise not technically.
Currently BlockEdit functions added by hooks implicitly subscribe to all attributes because they are children of the main BlockEdit function. In this PR, I make some of these pure and explicitly subscribe only to the relevant attributes.
I expect a performance benefit on typing because now these controls shouldn't re-render when the paragraph content attribute changes.
The more panels you have open, or the more controls show, the worse it is. By default, we only have color and typography open on paragraph.
Also:
setAttributesetc. as well and use the store instead.Why?
(*) To be investigated.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast