Update data view layout #56786
Merged
Update data view layout #56786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +227 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 906bcd6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7128092423
|
ntsekouras
reviewed
Dec 7, 2023
| overflow: auto; | ||
| padding: $grid-unit-40 $grid-unit-40 0; |
There was a problem hiding this comment.
Since we're removing the padding here, probably we want to add some padding when we have no results and when showing the loading message. Besides the padding though, it would be good to improve them too - better messages or spinner/progress bar etc..
There was a problem hiding this comment.
Good catch. I fixed the padding for this (and the loading state) for now. Ideally both need a fresh design but that can come later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates styling of various elements to get closer to this mockup by @SaxonF:
This PR
Why?
The visuals haven't been updated much since the initial implementation, and the design has evolved a little as we've added more features and layouts.
Details to handle separately
How?
Mostly CSS. Added a few classnames and props to components as required.
Testing Instructions