Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix top position and height of Pattern Modal Sidebar #56787

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix top position and height of Pattern Modal Sidebar #56787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/block-editor/src/components/inserter/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,15 +268,11 @@ $block-inserter-tabs-height: 44px;
}
}

.block-editor-inserter__block-patterns-tabs-container,
.block-editor-block-patterns-explorer__sidebar {
.block-editor-inserter__block-patterns-tabs-container {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will also remove the following selector.

.block-editor-block-patterns-explorer__sidebar nav {
  height:100%;
}

However, it seems that there are no elements matching this selector.

height: 100%;
nav {
height: 100%;
}
.block-editor-block-patterns__source-filter select.components-select-control__input {
height: 40px;
}
Comment on lines -277 to -279
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched the whole project for the keyword source-filter, but there doesn't seem to be any element with a class name containing that keyword. It existed in the past, but I don't think it exists now.

}

.block-editor-inserter__block-patterns-tabs {
Expand Down Expand Up @@ -445,7 +441,7 @@ $block-inserter-tabs-height: 44px;
.block-editor-block-patterns-explorer {
&__sidebar {
position: absolute;
top: $header-height + $grid-unit-20;
top: $header-height + $grid-unit-15;
left: 0;
bottom: 0;
width: $sidebar-width;
Expand Down
Loading