[Mobile] Fix crash when appending media (Android) #56791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 5, 2023 16:15
… files, it currently supports images and video only
… tests for subscribeMediaAppend
geriux
added
[Type] Bug
geriux
commented
Dec 5, 2023
|
|
||
| describe( 'Editor', () => { | ||
| it( 'detects unsupported block and sends hasUnsupportedBlocks true to native', () => { |
There was a problem hiding this comment.
I've removed this test because we have others that cover the Unsupported blocks functionality
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 6b90b4b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7168923434
|
12 tasks
geriux
commented
Dec 7, 2023
|
|
||
| this.props.insertBlock( newBlock, insertionIndex ); | ||
| } else { | ||
| createErrorNotice( |
There was a problem hiding this comment.
This will serve as a fallback, a few changes were done in wordpress-mobile/WordPress-Android#19754 to prevent passing unsupported files when sharing files to the editor.
derekblank
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM. I was able to test the Android changes successfully. I wasn't able to test the generated iOS build due to App Center being down, but I did not note any issues when testing with a local build on iOS. 🚀
Thank you for the review and testing! 🚀 |
geriux
removed
the
Mobile App - Automation
4 tasks
For reference, I observed that also in a production version, the editor takes several seconds to load (wordpress-mobile/gutenberg-mobile#6529). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Fixes wordpress-mobile/gutenberg-mobile#6443
What?
This PR fixes an issue when appending unsupported media types when using the Sharing functionality on Android devices.
The only way to be able to "Share" unsupported media types is when multi-selecting files that the app does support like images or videos.
Why?
To prevent the Android app from crashing.
How?
It adds a check using
getBlockTypeto make sure the dynamic block name'core/' + payload.mediaType;is registered correctly and that it exists.It also adds some tests for this functionality.
Testing Instructions
Android
PDF,jpg, andmp4.iOS
Testing Instructions for Keyboard
N/A
Screenshots or screencast
TestCase1.mov
IOS.mp4